Add sending contextmenu event to Desktop app #4063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkaz
added
the
[Status] Needs Review
…hould fix CircleCI complaining
mkaz
changed the title
| if ( config.isEnabled( 'desktop' ) ) { | ||
| const ipc = require( 'electron' ).ipcRenderer; // From Electron | ||
| editor.on( 'contextmenu', function( ev ) { | ||
| ipc.send( 'mce-context-menu', ev ); |
There was a problem hiding this comment.
We should probably name the event mce-contextmenu for consistency.
|
One small naming thing, but otherwise 👍 |
mjangda
referenced
this pull request
in Automattic/wp-desktop
Mar 16, 2016
… from IPC so needs extra check
mkaz
removed
the
[Status] Needs Review
mkaz
added a commit
that referenced
this pull request
Mar 16, 2016
Add sending contextmenu event to Desktop app
This was referenced Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to display the contextmenu within the visual editor, since it is in an iframe, we need to send the contextmenu event up to the app using IPC. With the Desktop app changes in Automattic/wp-desktop#116 the Context Menu will include spelling suggestions and copy/paste functionality.