Framework: update localforage to 1.4.0 & Fix Mobile Chrome on iOS #4169
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch updates
localforage
to version 1.4.0 which includes a fix for an infinite loop bug in localforage that makes calypso crash on both Chrome for iOS and Firefox for iOS ( fixes #4010 ).It appears that calypso on Chrome for iOS ( and Firefox on iOS - though I did not test ) have both been broken since localforage was first merged in as part of #2754 on February 3rd ( /cc @gwwar ).
To confirm that localforage was at fault, I checked out the last sha prior to
localforage
being added to ourpackage.json
:git checkout b2b578aa5df7981207ce8d8ae197f1605b2d1566
#And under this branch locally, calypso would load in Chrome for iOS.
Then when I checked out the next merge sha for package.json where
localforage
was added - the infinite loop / freeze was experienced:git checkout 69a7535499e9082df1e20113b9ec0c2c4c2883d3
#To Test
localforage
hat tip to @jblz for reporting the issue ( and hopefully you can test the fix )