Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: update localforage to 1.4.0 & Fix Mobile Chrome on iOS #4169

Merged
merged 1 commit into from
Mar 19, 2016

Conversation

timmyc
Copy link
Contributor

@timmyc timmyc commented Mar 19, 2016

This branch updates localforage to version 1.4.0 which includes a fix for an infinite loop bug in localforage that makes calypso crash on both Chrome for iOS and Firefox for iOS ( fixes #4010 ).

It appears that calypso on Chrome for iOS ( and Firefox on iOS - though I did not test ) have both been broken since localforage was first merged in as part of #2754 on February 3rd ( /cc @gwwar ).

To confirm that localforage was at fault, I checked out the last sha prior to localforage being added to our package.json:

git checkout b2b578aa5df7981207ce8d8ae197f1605b2d1566 #

And under this branch locally, calypso would load in Chrome for iOS.

Then when I checked out the next merge sha for package.json where localforage was added - the infinite loop / freeze was experienced:

git checkout 69a7535499e9082df1e20113b9ec0c2c4c2883d3 #

To Test

  • Checkout this branch with the updated version of localforage
  • Setup your iOS device to use charles proxy so you can load your local calypso
  • Confirm that calypso loads on Chrome iOS, and you can navigate to different sections

hat tip to @jblz for reporting the issue ( and hopefully you can test the fix )

@timmyc timmyc added Framework [Pri] High Address as soon as possible after BLOCKER issues labels Mar 19, 2016
@timmyc timmyc self-assigned this Mar 19, 2016
@jblz
Copy link
Member

jblz commented Mar 19, 2016

Confirmed fixed for me -- verified using Charles proxy.
Thanks very much for the fix!

@gwwar
Copy link
Contributor

gwwar commented Mar 19, 2016

Verified that normal localForage usage works. Thanks for the 🔍 and fix!

blowery added a commit that referenced this pull request Mar 19, 2016
Framework: update localforage to 1.4.0 & Fix Mobile Chrome on iOS
@blowery blowery merged commit d31e46c into master Mar 19, 2016
@blowery blowery deleted the update/localforage-version branch March 19, 2016 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework [Pri] High Address as soon as possible after BLOCKER issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS: Chrome Mobile -- App locks up & eventually errors out
5 participants