My Home: Try updating card mapping for Support card

[mmtr]

Changes proposed in this Pull Request

Explores the approach suggested in paYJgx-GU-p2 #comment-899 as an alternative to D43941-code.

This way, we re-use the existing FEATURE_SUPPORT card UID so the new Support Search card will be also used in future versions of the desktop app while keeping backwards compatibility with current and previous versions.

Testing instructions

Verify the Support Search shows up for all views, including the ones used on the desktop app. See #42752 (comment) for instructions about how to build a new desktop app version that includes the new Support Search card (I already generated it and confirmed it works as expected).

[matticbot]

Test live: https://calypso.live/?branch=update/home-help-search-mapping

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~533 bytes removed 📉 [gzipped])

name  parsed_size           gzip_size
home      -3278 B  (-0.8%)     -533 B  (-0.5%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[mmtr]

I generated a desktop app build using the Calypso snapshot currently fixed in develop (Automattic/wp-desktop#886) and cherry picking changes from #42625 and this PR:

cd calypso
git cherry-pick c16b863e4fea5a4c9c59dae3e35128f242f8198d
git cherry-pick 84108dd3519c1e9120878b910162b0af15de2f4b
cd ..
make build

The new Support Search card shows up and works as expected while current version (5.1.1) keeps displaying the old Support card.

Custom build	5.1.1

[gwwar]

Thanks @mmtr for proposing this and crafting the PR 💖

This tests well for me. Let's let @getdave pick the landing approach:

1. We either take My Home: Try updating card mapping for Support card #42752 and drop D43941-code
2. Or keep D43941-code and close My Home: Try updating card mapping for Support card #42752

Respectively each patch needs to land last, otherwise we'll see the card in production. Going to add DO NOT MERGE label until folks are happy with a landing choice.

[getdave]

Thanks @mmtr for proposing this and crafting the PR 💖

This tests well for me. Let's let @getdave pick the landing approach:

Thanks both. I'm assigned to work on this again this 2 week Iteration so I'll be sure to update when I've decided on an approach. Much appreciated!

[getdave]

Still discussing a decision on whether to merge this in paYJgx-GU-p2#comment-917.

[getdave]

We decided in paYJgx-GU-p2#comment-917 that this was the best route to take.

Let's land this just as soon as @retrofox has landed the tracking PR.

We also need to address the followups noted in #42744

[retrofox]

We decided in paYJgx-GU-p2#comment-917 that this was the best route to take.

Let's land this just as soon as @retrofox has landed the tracking PR.

Merging today in a few minutes...

[nsakaimbo]

👋 Thanks for proposing this solution, @mmtr - I think it's a good middle ground, given the alternatives.

Heads up that desktop CI is currently offline as there's a webpack-related issue that's being currently looked at in #42898.

Being as you tested this manually with a desktop build, I think this change is safe to land.