Update FSE plugin to version 1.11.0 #43857
Conversation
andrewserong
added
the
[Status] Needs Review
|
Caution: This PR affects files in the FSE Plugin on WordPress.com D45821-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing in the FSE Plugin for more info: PCYsg-ly5-p2 |
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
|
Unfortunately this doesn't include #43792 which I just have merged now. Could you do another run and update? Thanks! |
There was a problem hiding this comment.
- Block Patterns: Fix custom font size in previews Fix block pattern previews with custom font size #43546
- FSE Plugin: Block Pattern Preview Viewport Scaling Modify Block Pattern Preview Viewport #43362
✅ Works on simple sites
✅ Works on atomic sites
✅ Works on atomic site without the Gutenberg plugin
✅ Works on Calypso and wp-admin for all the mentioned sites
|
Thanks @akirk — I'll rebase and include it! |
andrewserong
force-pushed
the
update/fse-plugin-to-v-1-11
branch
from
8c72433
to
601d7d2
Compare
|
The change in #43792 to update the text domains for the newspack blocks doesn't seem to be working properly in the CI build. I've commented more fully over in that PR: #43792 (comment) |
| - name: Run composer | ||
| uses: nick-zh/composer-php@master | ||
| with: | ||
| action: 'install' |
There was a problem hiding this comment.
Are Composer packages cached in Circle CI?
There was a problem hiding this comment.
Could you elaborate on that question? We're using Github Actions here, no?
There was a problem hiding this comment.
🤦 hah, of course no circle ci here.
So e.g. node_modules gets cached so that running yarn is faster, and I was wondering if results from composer install also could get cached?
There was a problem hiding this comment.
Ah I am by no means an expert in this realm. All I can say that the time added by the composer install was really minimal, so I am not sure if it's worth trying to cache something.
There was a problem hiding this comment.
Sounds good then! :-) 👍 Thanks for checking the time.
matticbot
removed
the
[Status] Needs Review
This PR bumps the FSE plugin version to v1.11.0 for rolling out another release. It includes a fair few changes based on looking at https://github.com/Automattic/wp-calypso/commits/master/apps/full-site-editing. I've cross-referenced these below:
Included changes:
Testing instructions
If approving this PR, please approve D45821-code, too :)
@Automattic/serenity can you please double-check that the commits included in this release are working correctly? I'm not so familiar with the Donations or Premium Content blocks, so just want to make sure it's all good to go!