Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats: fix view all footer links in stats modules. #4508

Merged
merged 1 commit into from
Apr 4, 2016
Merged

Conversation

timmyc
Copy link
Contributor

@timmyc timmyc commented Apr 4, 2016

Fixes #4507
#2863 introduced a regression where the footer version of the "View All" link was not linking properly. This branch fixes that, even though we are considering removing these links all together in lieu of the header links.

To Test

  • Open a site stats page for a site with a decent amount of traffic
  • Click "View All" in the footer of the Post & Pages module
  • Validate the summary page opens as expected

/cc @folletto

@timmyc timmyc self-assigned this Apr 4, 2016
@timmyc timmyc added [Feature] Stats Everything related to our analytics product at /stats/ [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Apr 4, 2016
@folletto
Copy link
Contributor

folletto commented Apr 4, 2016

Tested on Chrome, works 👍

Thanks for the quick fix! :D

@timmyc timmyc merged commit 0598fcc into master Apr 4, 2016
@scruffian scruffian removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 4, 2016
@timmyc timmyc deleted the fix/stats/4507 branch April 4, 2016 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Stats Everything related to our analytics product at /stats/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stats: "View all" doesn't do anything
3 participants