Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR restores the unseen notification badge. Notification badge is enabled in Preferences. Based on existing code, this feature used to work in the past but seems to have silently broken at some point along the way.
How it Works
NOTIFICATIONS_UNSEEN_COUNT_SET
event to send the unseen count to the main process.isVisible
flag is overriden in Calypso'sapps/notifications
component in order to ensure that pinghub websocket polling continues even when the application's main window may be closed/hidden. In addition, this ensures that the notifications component continues to relay notification events when the application window is hidden or otherwise out of sight.Areas for Improvement
Will be looking at augmenting native notifications with actual notification messages as part of a separate effort/downstream PR. (Need to do more research/experimentation to see how to integrate/sync with Calypso's existing infrastructure.)