Add/migrate wp desktop teamcity #47368

scinos · 2020-11-12T13:57:07Z

Changes proposed in this Pull Request

Create TeamCity build for wp-desktop
Add junit reporter for mocha so tests can be reported in TeamCity
Add electron-*.log file to log Electron start up messages

Testing instructions

Go to TeamCity and verify there is a Desktop e2e tests build for this branch and it is passing.
Unfortunately not all features can be tested (eg: github notifications, tests reports) until this is merged (TeamCity doesn't like adding new features {} in a branch to an existing build).

matticbot · 2020-11-12T13:57:08Z

Test live: https://calypso.live/?branch=add/migrate-wp-desktop-teamcity

matticbot · 2020-11-12T13:57:54Z

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

desktop/e2e/run.js

…uild

.teamcity/settings.kts

scinos · 2020-11-13T05:10:08Z

.teamcity/settings.kts

+			param("xmlReportParsing.reportType", "junit")
+			param("xmlReportParsing.reportDirs", "desktop/e2e/result.xml")
+		}
+		perfmon {


Add a tab with info about CPU/Mem used by the build

.teamcity/settings.kts

scinos · 2020-11-13T05:12:10Z

.teamcity/settings.kts

+				filterAuthorRole = PullRequests.GitHubRoleFilter.EVERYBODY
+			}
+		}
+		commitStatusPublisher {


Add a notification in GitHub PR with the status of this build

.teamcity/settings.kts

scinos · 2020-11-13T05:18:36Z

desktop/e2e/run.js

@@ -18,6 +18,8 @@ const APP_ARGS = [
 	'--disable-http-cache',
 	'--start-maximized',
 	'--remote-debugging-port=9222',
+	'--disable-setuid-sandbox',


Without this Chrome throws lots of problems. This was also done in CircleCI at the image config in https://github.com/CircleCI-Public/circleci-dockerfiles/blob/master/node/images/12.18.4-stretch/browsers/Dockerfile#L46

wp-desktop

WordPress Desktop CI Failure for job "wp-desktop-mac".

@scinos please inspect this job's build steps for breaking changes at this link. For temporal failures, you may try to "Rerun Workflow from Failed".

Please also ensure this branch is rebased off latest Calypso.

wp-desktop ci passing, closing review

nsakaimbo · 2020-11-13T22:40:41Z

desktop/e2e/tests/lib/video-recorder.js

@@ -31,6 +31,10 @@ exports.createDir = function ( dir ) {

 exports.isVideoEnabled = function () {
 	const video = process.env.CI;
+	// eslint-disable-next-line no-console


Curious if including L34-L37 was intentional here? (I'm guessing this is useful to persist to the CI process logs for debugging?)

Good catch!
Leftovers from when I was trying to debug video recorder, deleted.

nsakaimbo · 2020-11-13T22:51:46Z

Looks really good! Couple of quick thoughts/question:

Is a "desktop" e2e CI badge supposed to be present on this PR? I only see the standard Calypso checks right now (I'm assuming this needs to get merged first?).

With your changes/additions to the linux container, I wonder if video capture for Linux is finally working? I attempted this a while ago - I got pretty far but ultimately failed (see here). Context: during my initial attempt, a file was saved but for some reason couldn't be viewed, so something was off somewhere.

Not a blocker for this PR at all but probably something I'll revisit at some point. The artifact is persisted to the desktop/e2e/screenshots directory - probably doesn't hurt to persist that location for inspection.

nsakaimbo

Thanks for your amazing and hard work here, @scinos! ❤️

I know this was very much a non-trivial effort and there were a number of technical hurdles to overcome.

Looking forward to getting this integrated into wp-calypso and streamlining the build/CI process for everyone!

scinos · 2020-11-16T06:12:20Z

Is a "desktop" e2e CI badge supposed to be present on this PR? I only see the standard Calypso checks right now (I'm assuming this needs to get merged first?).

I got the message "Unsupported change of build features in the build configuration" in TeamCity, I assume those will start working once we merge it.

With your changes/additions to the linux container, I wonder if video capture for Linux is finally working

I tried :) When it tries to spawn ffmpeg it fails with Unknown input format: 'avfoundation'. Google tells me that's a MacOS thing and we may need to refactor how video-recorder works to account for the OS. I was planning to revisit it in a followup PR.

The artifact is persisted to the desktop/e2e/screenshots directory

It should be persisted as soon as we generate any content. These are the dirs we persist (from https://github.com/Automattic/wp-calypso/pull/47368/files#diff-660a0483d27a7df9ef700886a52d2714ac135f25af6889269798e06d37fff664R665-R669)

desktop/release
desktop/e2e/logs
desktop/e2e/screenshots

scinos mentioned this pull request Nov 12, 2020

Attach a VCS config to the placeholder build #47369

Merged

nsakaimbo reviewed Nov 12, 2020

View reviewed changes

desktop/e2e/run.js Outdated Show resolved Hide resolved

scinos added 7 commits November 13, 2020 06:04

Add more logs to app startup

074c6fa

Create Desktop subproject in TeamCity

baa615c

Disable chrome sandbox

8185c5d

Use custom log file for electron startup

fde370c

Add junit-reporter for mocha

a771050

Add notifications, pull request support and test reports to desktop b…

46ac53f

…uild

Fix typo in kotlin

8819395

scinos force-pushed the add/migrate-wp-desktop-teamcity branch from b8cb03d to 8819395 Compare November 13, 2020 05:06

scinos commented Nov 13, 2020

View reviewed changes

.teamcity/settings.kts Show resolved Hide resolved

scinos commented Nov 13, 2020

View reviewed changes

.teamcity/settings.kts Show resolved Hide resolved

scinos commented Nov 13, 2020

View reviewed changes

.teamcity/settings.kts Show resolved Hide resolved

scinos commented Nov 13, 2020

View reviewed changes

scinos requested a review from a team November 13, 2020 05:19

matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 13, 2020

scinos requested a review from nsakaimbo November 13, 2020 05:19

scinos self-assigned this Nov 13, 2020

scinos marked this pull request as ready for review November 13, 2020 05:19

wp-desktop previously requested changes Nov 13, 2020

View reviewed changes

scinos added 2 commits November 13, 2020 06:42

Add multiple reports to mocha

50d93a8

Store screenshots artifact

cb1263f

scinos added 3 commits November 13, 2020 07:09

Use correct path for junit test results

a864546

Adds logs for video recorder

36cdf84

Set CI env var

f56f9aa

Clean up unused env vars

4a9901f

nsakaimbo reviewed Nov 13, 2020

View reviewed changes

nsakaimbo self-requested a review November 13, 2020 22:52

nsakaimbo approved these changes Nov 13, 2020

View reviewed changes

Clean up debug leftovers

72f1916

scinos merged commit 7ac5bd1 into master Nov 16, 2020

scinos deleted the add/migrate-wp-desktop-teamcity branch November 16, 2020 09:25

matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 16, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add/migrate wp desktop teamcity #47368

Add/migrate wp desktop teamcity #47368

scinos commented Nov 12, 2020 •

edited

Loading

matticbot commented Nov 12, 2020

matticbot commented Nov 12, 2020

scinos Nov 13, 2020

scinos Nov 13, 2020

scinos Nov 13, 2020

wp-desktop left a comment

nsakaimbo Nov 13, 2020 •

edited

Loading

scinos Nov 16, 2020

nsakaimbo commented Nov 13, 2020

nsakaimbo left a comment •

edited

Loading

scinos commented Nov 16, 2020 •

edited

Loading

Add/migrate wp desktop teamcity #47368

Add/migrate wp desktop teamcity #47368

Conversation

scinos commented Nov 12, 2020 • edited Loading

Changes proposed in this Pull Request

Testing instructions

matticbot commented Nov 12, 2020

matticbot commented Nov 12, 2020

scinos Nov 13, 2020

Choose a reason for hiding this comment

scinos Nov 13, 2020

Choose a reason for hiding this comment

scinos Nov 13, 2020

Choose a reason for hiding this comment

wp-desktop left a comment

Choose a reason for hiding this comment

nsakaimbo Nov 13, 2020 • edited Loading

Choose a reason for hiding this comment

scinos Nov 16, 2020

Choose a reason for hiding this comment

nsakaimbo commented Nov 13, 2020

nsakaimbo left a comment • edited Loading

Choose a reason for hiding this comment

scinos commented Nov 16, 2020 • edited Loading

scinos commented Nov 12, 2020 •

edited

Loading

nsakaimbo Nov 13, 2020 •

edited

Loading

nsakaimbo left a comment •

edited

Loading

scinos commented Nov 16, 2020 •

edited

Loading