-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shopping cart: Update StaleCartItemsNotice to use useShoppingCart #47970
Shopping cart: Update StaleCartItemsNotice to use useShoppingCart #47970
Conversation
This lets use use useEffect to postpone the notice display functionality until after render, preventing warnings that we cannot render while other renders are in-progress.
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Webpack Runtime (~20 bytes added 📈 [gzipped])
Webpack runtime for loading modules. It is included in the HTML page as an inline script. Is downloaded and parsed every time the app is loaded. App Entrypoints (~45 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~564 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~3825 bytes removed 📉 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I carried out the testing instructions; everything worked as expected and I saw no errors. Nice work!
Changes proposed in this Pull Request
As part of the effort to remove the deprecated
CartStore
, this PR updates theStaleCartItemsNotice
component so that it now usesuseShoppingCart
(part of the@automattic/shopping-cart
package).Screenshots
Testing instructions