Domains: Update RegisterDomainStep to use withShoppingCart and remove CartData #48437
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
This replaces the
CartData
wrapper aroundRegisterDomainStep
withwithShoppingCart
. This will help us eventually removeCartData
(see #24019).The only thing I wasn't able to determine is if there was a reason why
CartData
was only being used in signup if'launch-site' === this.props.flowName
. If the cart should be ignored otherwise, we may need to add some additional logic insideRegisterDomainStep
to ignorecart
in that case. That code originated in #42162 so I'm pinging @eltongo for advice!Testing instructions
Unknown. Help me Obi Wan Cobalt! You're my only hope!