Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domains: Update RegisterDomainStep to use withShoppingCart and remove CartData #48437

Merged
merged 2 commits into from
Jan 4, 2021

Conversation

sirbrillig
Copy link
Member

@sirbrillig sirbrillig commented Dec 17, 2020

Changes proposed in this Pull Request

This replaces the CartData wrapper around RegisterDomainStep with withShoppingCart. This will help us eventually remove CartData (see #24019).

The only thing I wasn't able to determine is if there was a reason why CartData was only being used in signup if 'launch-site' === this.props.flowName. If the cart should be ignored otherwise, we may need to add some additional logic inside RegisterDomainStep to ignore cart in that case. That code originated in #42162 so I'm pinging @eltongo for advice!

Testing instructions

Unknown. Help me Obi Wan Cobalt! You're my only hope!

@sirbrillig sirbrillig requested a review from a team December 17, 2020 00:50
@sirbrillig sirbrillig self-assigned this Dec 17, 2020
@matticbot
Copy link
Contributor

@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 17, 2020
@sirbrillig sirbrillig added [Feature Group] Emails & Domains Features related to email integrations and domain management. [Feature] Shopping Cart Anything related to the shopping cart in Calypso, like adding items to the cart, the mini-cart, etc. labels Dec 17, 2020
@sirbrillig sirbrillig mentioned this pull request Dec 17, 2020
@matticbot
Copy link
Contributor

matticbot commented Dec 17, 2020

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~24 bytes added 📈 [gzipped])

name     parsed_size           gzip_size
domains        +55 B  (+0.0%)      +24 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~3322 bytes added 📈 [gzipped])

name                             parsed_size           gzip_size
async-load-signup-steps-domains     +11260 B  (+4.2%)    +3322 B  (+5.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@sirbrillig sirbrillig force-pushed the update/register-domain-step-with-shopping-cart branch from 5a644e2 to a95e91f Compare December 17, 2020 18:06
@sirbrillig sirbrillig requested a review from eltongo December 17, 2020 18:07
Copy link
Contributor

@eltongo eltongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We can definitely pass the cart data regardless of what the current flow is.

@eltongo eltongo added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 24, 2020
@sirbrillig sirbrillig merged commit b3b5da3 into trunk Jan 4, 2021
@sirbrillig sirbrillig deleted the update/register-domain-step-with-shopping-cart branch January 4, 2021 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Estimate] 1 [Feature Group] Emails & Domains Features related to email integrations and domain management. [Feature] Shopping Cart Anything related to the shopping cart in Calypso, like adding items to the cart, the mini-cart, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants