Checkout: remove handleCheckoutCompleteRedirect

[sirbrillig]

Changes proposed in this Pull Request

This removes the handleCheckoutCompleteRedirect function from old checkout's Checkout component. The last place it was being used was the (disabled) post-purchase G Suite upsell nudge and that usage has been removed with #48438.

This should help confusion around where the post-purchase thank-you page comes from, since it will now always be generated by getThankYouPageUrl.

Testing instructions

None. Make sure the removed code isn't in use anywhere.

[matticbot]

Test live: https://calypso.live/?branch=remove/handle-checkout-complete-redirect

[pottedmeat]

This removes a number of props from <Checkout> that are still passed by <CheckoutContainer> that could be removed:

• couponCode
• returnToBlockEditor
• returnToHome
• selectedFeature
• purchaseId
• plan
• reduxStore
• redirectTo
• upgradeIntent
• hideNudge
• infoMessage

It also looks like there are props used in <Checkout> (and passed by <CheckoutContainer>/<CartData>) but not in propTypes:

• cart
• product
• setHeaderText
• isFetchingStoredCards

[pottedmeat]

I think it's also worth removing the class export.

[pottedmeat]

Is it worth worrying about any of this stuff? It looks like we might pull out the rest of this code soon.

[sirbrillig]

Good eye. I rebased and I think we've finally got all of the code in this directory, but it's a lot, so I've split it into two PRs. This one will just remove handleCheckoutCompleteRedirect since I'm certain that's not being used and #48512 will handle Checkout and CheckoutContainer.

[pottedmeat]

Cool. There's also some unused stuff in the mapped prop functions in connect.

[matticbot]

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.