-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Email: Create Titan Mail checkout flow #48600
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~22 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~5193 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~269 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a functional point of view, LGTM. I tested without the feature flag and did not notice any regressions.
The only functional nitpick is about how these products are rendered in the shopping cart:
We need to include the domain part somewhere in there, otherwise it's completely unclear which one if for which domain. It's also not visible how many items (emails) you're buying and I think that's a very useful information to include. Apologies if this is already on your radar 🙇
Code-wise, there's the suggestion about using selectors, but that's pending Payton's feedback. Since this is behind a feature flag, it should be to safe to merge as-is and iterate, especially if it's blocking further PRs.
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/5378831 Thank you @eltongo for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Changes proposed in this Pull Request
This PR creates the checkout flow for Titan Mail.
Testing instructions
titan/phase-2
flag by appending?flags=titan/phase-2
to the Calypso URLVerify that Cancel button works as expected by sending you to the /email page, and the Continue button adds the product to the cart.