Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader: fix /following route #48749

Merged
merged 1 commit into from
Jan 14, 2021
Merged

Conversation

bluefuton
Copy link
Contributor

Changes proposed in this Pull Request

While working on some routing changes (D45105-code) I noticed that Calypso doesn't handle the /following route but it does handle /following/manage and /following/edit.

Working on the principle that good URLs should be hackable, and therefore that some users will end up at /following even though we're not linking to it anywhere, this PR adds a redirect to /read from that route.

Testing instructions

@bluefuton bluefuton added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature] Reader The reader site on Calypso. [Type] Janitorial labels Jan 10, 2021
@bluefuton bluefuton added this to the Reader: Bug Backlog milestone Jan 10, 2021
@bluefuton bluefuton requested a review from jsnmoon January 10, 2021 23:03
@bluefuton bluefuton requested a review from a team as a code owner January 10, 2021 23:03
@bluefuton bluefuton self-assigned this Jan 10, 2021
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~4 bytes added 📈 [gzipped])

name    parsed_size           gzip_size
reader        +26 B  (+0.0%)       +4 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@jsnmoon jsnmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Works as described.

@bluefuton bluefuton merged commit 190a6d0 into trunk Jan 14, 2021
@bluefuton bluefuton deleted the add/reader-following-route-redirect branch January 14, 2021 00:51
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Reader The reader site on Calypso. [Type] Janitorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants