Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnchorFM Signup Required Params #49066

Closed
wants to merge 1 commit into from

Conversation

krymson24
Copy link
Contributor

Changes proposed in this Pull Request

  • Makes the Spotify Show URL and Podcast Episode params required on signup

Note: This is just a proposal PR to experiment with this updated experience

Testing instructions

GIFs

2021-01-19 23 05 50

Fixes #419-gh-Automattic/dotcom-manage

@krymson24 krymson24 added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 20, 2021
@krymson24 krymson24 requested a review from a team January 20, 2021 07:07
@krymson24 krymson24 self-assigned this Jan 20, 2021
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~11 bytes added 📈 [gzipped])

name                 parsed_size           gzip_size
entry-gutenboarding        +51 B  (+0.0%)      +11 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@krymson24 krymson24 closed this Jan 21, 2021
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jetpack Plugins: Add InfoPopup explaining why the site can't be auto updated
2 participants