Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media: Allow gallery captioned to be emptied #496

Merged
merged 1 commit into from
Nov 23, 2015

Conversation

aduth
Copy link
Contributor

@aduth aduth commented Nov 23, 2015

This pull request seeks to resolve an issue where it was previously not possible to remove all text from an image caption in the media modal gallery edit panel. Without these changes, when a user would try to remove all text from the caption field, it would immediately reset to the original value.

Before:

before

After;

after

Testing instructions:

Verify that you can remove all characters from the gallery caption field to remove the caption from an image.

  1. Navigate to the Calypso post editor
  2. Select a site, if prompted
  3. Click the media button in the editor toolbar
  4. Select two or more images from your media library
    • At least one of which should already have a caption. You can add a caption by clicking the Edit button before proceeding to the gallery screen
  5. Click Continue in the modal action bar
  6. Change to the gallery Edit tab
  7. Remove all characters from the captioned field
  8. Note that you can remove all characters from the field
  9. Insert the gallery to the post or click the Preview tab
  10. Note that the caption removal persists through insertion/preview

@aduth aduth added [Feature] Post/Page Editor The editor for editing posts and pages. [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature] Media The media screen in Calypso, general media management, or integration with third party media. labels Nov 23, 2015
@aduth aduth self-assigned this Nov 23, 2015
@kellychoffman
Copy link
Member

👍 Caption successfully removed.

@mtias
Copy link
Member

mtias commented Nov 23, 2015

👍

@mtias mtias added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 23, 2015
aduth added a commit that referenced this pull request Nov 23, 2015
Media: Allow gallery captioned to be emptied
@aduth aduth merged commit 01b1201 into master Nov 23, 2015
@aduth aduth deleted the fix/media-gallery-caption-empty branch November 23, 2015 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Media The media screen in Calypso, general media management, or integration with third party media. [Feature] Post/Page Editor The editor for editing posts and pages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants