-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nav Unification: Open wp-admin links on new tabs (Jetpack sites only) #50444
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Async-loaded Components (~87 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works well from user perspective. I left some comments, let me know your thoughts!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for refactoring this! It looks and works great now and code is simplified! LGTM, 🚢 !
Changes proposed in this Pull Request
Ensures that all menu items linking to
/wp-admin
URLs are marked as external and opened in new tabs for Jetpack sites.This improves the nav unification experience for Jetpack sites, since WP Admin is considered a separate area on those sites.
Testing instructions
update/admin-menu-jetpack-sites
branch (Admin Menu: Mimic existing Calypso menu on Jetpack sites jetpack#18921)./wp-admin
URLs (Feedback, Customize, Import, Export, WP Admin) are marked as external and they open pages in a new tab.Fixes (partially) #50438