Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav Unification: Update fallback menu for Jetpack sites #50522

Merged
merged 1 commit into from
Feb 26, 2021

Conversation

mmtr
Copy link
Member

@mmtr mmtr commented Feb 26, 2021

Changes proposed in this Pull Request

Updates the fallback menu used for Jetpack sites so it's aligned with the latest changes we introduced for the dynamic menu in Automattic/jetpack#18921, in which we removed most of the submenus.

Before After
Feb-26-2021 11-13-55 Feb-26-2021 11-44-35

Testing instructions

  • Switch to a Jetpack site and go to Posts.
  • Delete the IndexedDB database and reload the page.
  • Make sure there are no submenus flashing up.

Part of #50225.

@mmtr mmtr added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. labels Feb 26, 2021
@mmtr mmtr self-assigned this Feb 26, 2021
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Async-loaded Components (~7 bytes removed 📉 [gzipped])

name                                         parsed_size           gzip_size
async-load-calypso-my-sites-sidebar-unified       -488 B  (-0.3%)       -7 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@tjcafferkey tjcafferkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as described! 🚀

@mmtr mmtr merged commit c6f1b9c into trunk Feb 26, 2021
@mmtr mmtr deleted the update/nav-unification-jetpack-fallback branch February 26, 2021 16:06
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants