Domains: better error handling for initial domains suggestion search #5222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwwar
added
[Status] Needs Review
|
I could't reproduce an error but not in this line.
I did it in line 312. BTW the error handling here is very similar to the changes in this PR. |
|
Just a note, we need test this in singup flow and while the domain registrations are disabled as well. |
|
The error is for default suggestions. Just return |
aidvu
added
[Status] Ready to Merge
and removed
[Status] Needs Review
|
LGTM Before fix: After fix: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds better error handling when we cannot find any default domain suggestions. We normally shouldn't hit this case, but we may see this when we encounter timeouts on WWD.
Before:
After:
cc @umurkontaci @rralian @aidvu