Invites: Fix JS error caused from polling sites

[ebinnion]

Today, I noticed that a JS error was occurring for logged out invites.

To reproduce:

• Go to /people/new/$site where $site is a WP.com site
• Send an invite to a non-user
• Click link in your email
• Check console

After digging in, it looks like the error was coming from this line:

https://github.com/Automattic/wp-calypso/blob/master/client/layout/index.jsx#L62

Specifically, trying to add a poller to this.props.sites even when the user is logged out. To fix this, I simply removed the accept-invite path from the sites group.

I tested accepting invites afterward, and it worked. But frankly, I'm not sure if this will cause issues with chunking or anything else. I did notice several other sections did not have groups set, so my guess is no. All the same, pining @mtias who has a better idea.

To test:

• Checkout fix/invites-poller-js-error branch
• Go to /people/new/$site where $site is a WP.com site
• Send an invite to a non-user
• Get link from email and replace wordpress.com with calypso.localhost:3000
• Check console

Error on production:

No error with this branch in development:

cc @lezama for code review.

[mtias]

How does it work if you are logged in? The sites group highlights the "My Sites" item in the masterbar if you are logged in. Not sure if that's a requirement for this section.

[ebinnion]

Here is what a logged in invite looks like:

The "My Sites" menu item isn't highlighted as you predicted. Frankly, since we don't show the "My Sites" sidebar, I would suggest we not highlight the "My Sites" menu item either. I'll ping @rickybanister to get some input there.

[rickybanister]

I don't think that tab needs to be highlighted at the stage. You're sort of in limbo until you choose to join or decline.

[mtias]

Sounds good to me :)