Themes: ES6ify all the things #5315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ockham
added
[Feature Group] Appearance & Themes
ockham
force-pushed
the
update/themes-es6ify
branch
from
733eff5 to
ca472ca
Compare
| const oldShowcaseUrl = '//wordpress.com/themes/'; | ||
|
|
||
| export function getSignupUrl( theme ) { | ||
| let url = '/start/with-theme?ref=calypshowcase&theme=' + theme.id; |
There was a problem hiding this comment.
I think it's a nice opportunity to apply templates literals
let url = `/start/with-theme?ref=calypshowcase&theme${ theme.id }`;There was a problem hiding this comment.
TBH, I'd like to stick with simple concatenation here, since it's only two strings (plus, concatenation is more efficient than template strings ;-) )
|
|
No, that's pretty much it. Plus the usual ES6 stuff ( |
ockham
force-pushed
the
update/themes-es6ify
branch
from
feca13d to
ba9546e
Compare
|
Rebased on |
|
I don't see anything suspicious here. Seems fine with brief testing. 🚢 |
ockham
force-pushed
the
update/themes-es6ify
branch
from
ba9546e to
0479147
Compare
matticbot
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ES6ifies most if not all of
my-sites/themes, and then some. Main objective is more granular imports ofhelpers(no morethisreferences), and generally better ease-of-use (e.g. to also replacesignupandcustomizeactions by theirget...Url()counterparts further down the road, cf #5284).This is a change that touches a lot of files, so be sure to give it a thorough testing (try different flows in the theme showcase, be sure to cover all possible actions; use e2e tests!)