Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JavaScript syntax highlighting on GitHub #53532

Merged
merged 1 commit into from
Jun 9, 2021

Conversation

david-szabo97
Copy link
Contributor

@david-szabo97 david-szabo97 commented Jun 9, 2021

Changes proposed in this Pull Request

Related Linguist PR: github-linguist/linguist#5133

Testing instructions

@david-szabo97 david-szabo97 requested review from sirreal and a team June 9, 2021 08:01
@david-szabo97 david-szabo97 self-assigned this Jun 9, 2021
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jun 9, 2021
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Member

@jsnajdr jsnajdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, thanks for fixing this 👍

I don't think we can test this without merging it.

For a moment, I was able to see the fixed highlighting by viewing the *.js file from the PR branch:

https://github.com/Automattic/wp-calypso/blob/fix/github-javascript-syntax-highlighting/client/devdocs/index.js

But a minute later the highlighting was broken (i.e., no highlighting) again 🤷‍♂️

For reference: the .gitattributes attribute was originally added by @sirreal in #28459.

Copy link
Member

@sirreal sirreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@david-szabo97
Copy link
Contributor Author

For a moment, I was able to see the fixed highlighting by viewing the *.js file from the PR branch:

Actually, that worked for me after doing a force refresh. Probably it's related to some caching. But I can test this PR using this way, so just updated the PR description.

@david-szabo97 david-szabo97 merged commit 3b4eef9 into trunk Jun 9, 2021
@david-szabo97 david-szabo97 deleted the fix/github-javascript-syntax-highlighting branch June 9, 2021 08:33
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 9, 2021
@tyxla
Copy link
Member

tyxla commented Jun 9, 2021

Thanks for this @david-szabo97!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants