-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix JavaScript syntax highlighting on GitHub #53532
Conversation
Link to Calypso live: https://calypso.live?image=registry.a8c.com/calypso/app:build-7623 |
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well, thanks for fixing this 👍
I don't think we can test this without merging it.
For a moment, I was able to see the fixed highlighting by viewing the *.js
file from the PR branch:
But a minute later the highlighting was broken (i.e., no highlighting) again 🤷♂️
For reference: the .gitattributes
attribute was originally added by @sirreal in #28459.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Actually, that worked for me after doing a force refresh. Probably it's related to some caching. But I can test this PR using this way, so just updated the PR description. |
Thanks for this @david-szabo97! |
Changes proposed in this Pull Request
Related Linguist PR: github-linguist/linguist#5133
Testing instructions