Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebPreview: Allow externalUrl to be set for the external link button #5550

Merged
merged 1 commit into from
May 26, 2016
Merged

WebPreview: Allow externalUrl to be set for the external link button #5550

merged 1 commit into from
May 26, 2016

Conversation

ehg
Copy link
Member

@ehg ehg commented May 24, 2016 •
edited
Loading

When previewing a post or site, the external link shouldn't contain iframe specific qargs, which trigger iframe specific behaviour (no masterbar, rewritten links). Let's specify an externalUrl instead. This will also help with copy and pasted links not containing ugly qargs.

screen shot 2016-05-25 at 17 03 49

  • Modify the EditorPreview & DesignPreview accordingly

To test:

  1. Edit/add a new post/page.
  2. Open the preview
  3. Check the external link is void of any iframe args (p is fine, and expected)
  4. Click the site card
  5. Check the link qargs again.

@ehg ehg added this to the GuidedTours M2: Preview & Polish milestone May 24, 2016
@ehg ehg self-assigned this May 24, 2016
@lsinger lsinger mentioned this pull request May 24, 2016
Merged
@ehg ehg force-pushed the add/external-url-to-webpreview branch from fa66d33 to 4da2191 Compare May 25, 2016 15:59
@ehg ehg added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature] Post/Page Editor The editor for editing posts and pages. and removed [Status] In Progress labels May 25, 2016
@folletto
Copy link
Contributor

YES!!!

@lsinger
Copy link
Contributor

lsinger commented May 26, 2016 •
edited
Loading

LGTM. Squash / prettify commit(s) + :shipit:! 🎉

@lsinger lsinger force-pushed the add/external-url-to-webpreview branch from 847704f to 922db92 Compare May 26, 2016 12:28
@lsinger lsinger added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels May 26, 2016
@ehg ehg force-pushed the add/external-url-to-webpreview branch from 922db92 to 7fe4d0a Compare May 26, 2016 12:30
@ehg
WebPreview: Allow url to be set for the external link button
fc24a4e 
- Add `externalUrl` prop to WebPreview
- Modify EditorPreview to pass an externalUrl, and clean query args.
  This avoids modifying the Flux store.
- Pass externalUrl to DesignPreview
@ehg ehg force-pushed the add/external-url-to-webpreview branch from 7fe4d0a to fc24a4e Compare May 26, 2016 12:33
@lsinger lsinger merged commit f5363d1 into master May 26, 2016
@lsinger lsinger deleted the add/external-url-to-webpreview branch May 26, 2016 12:37
folletto added a commit that referenced this pull request May 30, 2016
@folletto
Add: use "non preview" url for external open of theme demo site.
9fc4bc8 
Possible thanks to #5550.
@folletto folletto mentioned this pull request May 30, 2016
Merged
folletto added a commit that referenced this pull request Jun 1, 2016
@folletto
Add: use "non preview" url for external open of theme demo site. (#5666)
c0cbb68 
Possible thanks to #5550.
@jeremeylduvall jeremeylduvall mentioned this pull request Apr 11, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ehg ehg

Labels
[Feature] Post/Page Editor The editor for editing posts and pages. Framework Guided Tours
Projects
None yet
Milestone
GuidedTours M2: Preview & Polish
Development

Successfully merging this pull request may close these issues.
4 participants
@ehg @folletto @lsinger @matticbot