Docs: Include paragraph about SCREAMING_SNAKE_CASE constants (JS) #5819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
Documentation
Framework
[Status] Needs Review
|
While I was going to try and use Snakes on a Plane to make a joke here, it is early Monday, and I have yet to consume the requisite quantity of coffee to do so. But the doc changes LGTM. |
timmyc
added
[Status] Ready to Merge
and removed
[Status] Needs Review
Screaming snake case? https://www.youtube.com/watch?v=amYzBQMT4VI |
|
|
|
👍 |
|
Thanks for the reviews (and suitably appropriate gif @gwwar 😆 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #5743 (comment)
This pull request seeks to add a paragraph to our JavaScript coding standards about the use of "screaming snake case" naming convention for constant values. This naming convention is already quite widespread in the application, but is not documented.
Testing instructions:
No application changes included.
Ensure that the paragraph and example are readable and the use of "screaming snake case" (a term I'd not seen used previously) is well-understood.
/cc @timmyc @mtias @nb