Importer: Continue reduxification work #5936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmsnell
added
[Status] Needs Review
dmsnell
force-pushed
the
update/importer-redux/start-import
branch
from
da0e59a to
d0e9e29
Compare
| startImport: flowRight( dispatch, startImport ) | ||
| } ); | ||
|
|
||
| export default connectDispatcher( null, mapDispatchToProps )( ImporterHeader ); |
There was a problem hiding this comment.
mapDispatchToProps can also be an object:
export default connectDispatcher( null, { startImport } )( ImporterHeader );https://github.com/reactjs/react-redux/blob/master/docs/api.md#arguments
There was a problem hiding this comment.
Oops - haha. This isn't connect - it's my transition function which doesn't have that property. Reverting the changes…
There was a problem hiding this comment.
Ah missed the dispatcher-converter there.
|
👍 Looks good |
gwwar
added
[Status] Ready to Merge
and removed
[Status] Needs Review
Updates the `startImport` action, which is one of the few actions that can be simply converted without getting into thunk issues.
dmsnell
force-pushed
the
update/importer-redux/start-import
branch
from
d0e9e29 to
1f17a25
Compare
|
@gwwar thanks for the review - I'm changing I'll merge after the tests pass. |
dmsnell
force-pushed
the
update/importer-redux/start-import
branch
from
1f17a25 to
a0ccf55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #5303
Updates the
startImportaction, which is one of the few actions thatcan be simply converted without getting into thunk issues.
No functional or stylistic changes are intended.
Testing
Navigate to My Sites > Settings > Import and attempt to start a new import from the collapsed import panel; either WordPress or Medium will work. If an import session is currently in progress, cancel it and try to start a new one. This is mostly a smoke-test.
cc: @roundhill @rodrigoi
Test live: https://calypso.live/?branch=update/importer-redux/start-import