-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CPT: Enable type toggles for supported Jetpack versions #6722
Conversation
} | ||
|
||
return ( | ||
site.versionCompare( '4.2.0', '>=' ) >= 0 && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this be site.versionCompare( '4.2.0', '>=' ) &&
- since versionCompare
returns a boolean?
I tested this out against a site that is running 4.1.1 and I was still seeing the |
b81aa6c
to
9d8f828
Compare
Rebased and pushed an alternate solution using |
Working as expected now. 🚢 |
9d8f828
to
538f3c0
Compare
Related: #4502
Related: #6105
Blocked by: #4369
This pull request seeks to allow Jetpack sites running supported versions and having enabled the "Custom Content Types" feature to toggle the active custom post types for their site.
Testing instructions:
As noted above, this is blocked by #4369. It is not currently possible to change the active setting of a custom post type without these changes. Pending future release or with these changes applied manually to your Jetpack site (and meeting or changing the
versionCompare
version), verify that you can toggle custom post types on a site.Test live: https://calypso.live/?branch=update/cpt-jetpack-writing-settings