Editor: Bind EditorPageOrder to Redux state #7166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
[Feature] Post/Page Editor
| if ( isNaN( newOrder ) ) { | ||
| newOrder = 0; | ||
| editMenuOrder( event ) { | ||
| const newOrder = parseInt( event.target.value ) || 0; |
There was a problem hiding this comment.
my favorite variable name. each time i read it, i must listen to https://www.youtube.com/watch?v=9GMjH1nR0ds
There was a problem hiding this comment.
Wow, that music video...
There was a problem hiding this comment.
Right?! Pretty cutting edge for back in the day
timmyc
added
[Status] Ready to Merge
and removed
[Status] Needs Review
|
This is working well for me in pages and cpts as well. |
aduth
force-pushed
the
update/editor-redux-page-order
branch
from
b70ff93 to
9c9f275
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #6548
This pull request seeks to refactor the
<EditorPageOrder />component to use Redux state exclusively for both displaying the current value and editing the value of themenu_orderpost field. Unless I'm mistaken, this would be the first production editor field using Redux state.It also makes minor usability improvements to render the
<input />as a proper number field, so that arrow keys can be used to change order and a number input is shown on mobile devices (at least iOS).Testing instructions:
Verify that there are no regressions in using the page order field. Notably, ensure that the post becomes saveable after changing the order, and that saving the post persists the order in the current session and after refresh.
Test live: https://calypso.live/?branch=update/editor-redux-page-order