Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update node-v0.12.6 to v0.12.8 #719

Closed
wants to merge 1 commit into from
Closed

Update node-v0.12.6 to v0.12.8 #719

wants to merge 1 commit into from

Conversation

thom4parisot
Copy link

Also declare NODE_VERSION as a way to simplify the maintenance of this bit.

Update node-v0.12.6 to v0.12.8
9c2c536 
Also declare NODE_VERSION as a way to simplify the maintenance of this bit.
@nb nb added Build [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 25, 2015
@sirbrillig
Copy link
Member

Good idea. However, NODE_VERSION was added in #730. Not sure if that was inspired by your PR or not (looks like the same day), but at least it got in there! The version update may be moot as we're moving toward node 4+ in #1204 so I'm going to close this for now, but thank you for the contribution!

@sirbrillig sirbrillig closed this Dec 4, 2015
@scruffian scruffian removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 4, 2015
@thom4parisot thom4parisot deleted the patch-1 branch December 6, 2015 21:15
@thom4parisot
Copy link
Author

You're welcome :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Build OSS Citizen
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thom4parisot @sirbrillig @nb @lancewillett @scruffian