Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ETK][GB 15.2.x] Patch the modules in @wordpress/interface@4.8.0 to match recent changes in Gutenberg 15.2.x #73856

Merged

Conversation

fullofcaffeine
Copy link
Contributor

@fullofcaffeine fullofcaffeine commented Feb 28, 2023

Simpler workaround to #73629. And it works!

Solves the WPCOM WSOD caused by Gutenberg 15.2. You can read about the issue in the PR above.

Proposed Changes

Patches the @wordpress/interface@4.8.0 (using yarn patch-package) with the relevant changes from #73629. This allows us to surgically update the code with the needed changes without update the package to its latest version, which turned out to be a more complicated process than we initially thought (see this Slack thread for more about that: p1677172931351469/1677020860.615489-slack-CBTN58FT).

Testing Instructions

  1. Install Gutenberg 15.2.2 in your WPCOM sandbox
  2. Try to create a new post or page
  3. You'll see the editor crash
  4. Now build and sync ETK from this branch to your sandbox (yarn && yarn dev --sync)
  5. Try to create a new page or post
  6. Profit! The editor works now :)

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@github-actions
Copy link

github-actions bot commented Feb 28, 2023

@fullofcaffeine fullofcaffeine requested a review from a team February 28, 2023 01:02
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 28, 2023
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see patching worked well 👍

Given the circumstances and the fact that this is blocking the Gutenberg upgrade on .com, I'm inclined to go ahead with this strategy.

We should still prioritize upgrading @wordpress packages and getting the regular updates up to speed ASAP since more problems like this will come in the future, and more patches like this may make it even more difficult to safely upgrade in the future.

LGTM ✅ 🚀

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@fullofcaffeine fullofcaffeine merged commit 209c37b into trunk Feb 28, 2023
@fullofcaffeine fullofcaffeine deleted the fix/gb-15.2-etk-wsod-by-patching-wp-interface-npm branch February 28, 2023 16:12
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants