Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hosting Command Palette: fix active descendant id for reserved characters #84412

Conversation

sejas
Copy link
Member

@sejas sejas commented Nov 22, 2023

Proposed Changes

  • Avoid accessing the DOM and just calculate the same ID for item and active descendant.

Testing Instructions

Screencast

ascendant.mp4

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

Copy link

github-actions bot commented Nov 22, 2023

Link to live branch is being generated...
Please wait a few minutes and refresh this page.

@sejas sejas changed the title Update/command palette slugify active descendant Hosting Command Palette: fix active descendant id for reserved characters Nov 22, 2023
@sejas sejas changed the base branch from trunk to fix/trim-double-quotes-in-command-palette November 22, 2023 12:42
@matticbot
Copy link
Contributor

matticbot commented Nov 22, 2023

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~46 bytes added 📈 [gzipped])

name                     parsed_size           gzip_size
sites-dashboard               +318 B  (+0.1%)      +61 B  (+0.0%)
import-hosted-site-flow       +318 B  (+0.0%)      +70 B  (+0.0%)
import-flow                   +318 B  (+0.0%)      +70 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@sejas sejas merged commit fd8dae6 into fix/trim-double-quotes-in-command-palette Nov 22, 2023
8 of 12 checks passed
@sejas sejas deleted the update/command-palette-slugify-active-descendant branch November 22, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants