Fix the line height for select lists in Chrome #8470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisterscott
added
Framework
[Status] Needs Review
aduth
added
[Status] Ready to Merge
and removed
[Status] Needs Review
alisterscott
force-pushed
the
fix/select-list-line-height-for-chrome
branch
from
d8fa807 to
c6098ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8469 which means select lists cut-off vertically in Chrome
Before PR (Chrome)
After PR (Chrome)
Testing Instructions
Visit https://calypso.live/me/account?branch=fix/select-list-line-height-for-chrome in Chrome and check that English shows the full word now - compare to https://wordpress.com/me/account
Check other browsers are still displaying select lists with correct heights - I have checked Firefox, Safari, MS Edge, MS IE 11, and iOS Safari.