-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Live Preview in Premium/Woo themes] Add tracking events #85526
Conversation
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~20 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
d4f16b6
to
9d2fe14
Compare
We could also track when upgrade modal is closed via user-interaction:
WDYT? @okmttdhr @autumnfjeld |
This event should include the word modal, maybe: or You can see other modal events by searching for "modal" in tracks events. |
That could be interesting, like a measure of curiosity about upgrading.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good 👍
f636b91
to
48faaa1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🙂
Related to #79223
Proposed Changes
This PR adds tracking events for "Live Preview in Premium/Woo themes". I added the following events;
calypso_block_theme_live_preview_click_upgrade-> calypso_block_theme_live_preview_upgrade_modal_upgradeWe can include the
wpcom_product_purchase
event (for checkout completion) and thewpcom_block_editor_save_click
event (for theme activation) in funnels.Testing Instructions
Please Test it on https://horizon.wordpress.com/.
install-plugin.sh wpcom-block-editor add/live-preview-track-event
on your sandbox.Upgrade now
button.escape
keyUpgrade plan
button on the modal.Pre-merge Checklist