-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetpack Manage: 192 - add NextSteps component to Overview page #85675
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~1673 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~50 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
return ( | ||
<div className="next-steps"> | ||
<div className="next-steps__header"> | ||
<h2>{ isCompleted ? translate( '🎉 Congratulations!' ) : translate( 'Next Steps' ) }</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yashwin suggested in #85488 (comment) to separate the emoji from the text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless there's a good reason to change it, I think it's best to keep it as-is. Splitting it means less flexibility for translators, which in general is a bad idea (though honestly I prefer no emojis).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from my comment, the code looks good and works as advertised!
Great job!
Approving this as my comment is not a blocker.
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/10456794 Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Thank you @tbradsha for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Resolves Automattic/jetpack-manage#192 - add NextSteps component to Overview page
Proposed Changes
This introduces a
NextSteps
component for the Overview page. Of note:<=600px
).Originally I found the
Launchpad
component, but in the end it is tightly integrated with Calypso Blue and would require implementing a new set of listeners + API calls, so I dug a bit deeper and used theChecklist
component it uses internally.Testing Instructions
One can manually update the
completed
booleans for each task and see the correct states. Tracks should fire when clicking on each task and when dismissing the dialog.The hidden task can be brought back by clearing the key out of
localStorage
:delete localStorage.jetpack_manage_hide_next_steps;
No tasks completed:
Two tasks completed:
Fully completed:
Pre-merge Checklist