Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add digest category to email notifications settings #8573

Merged
merged 1 commit into from
Oct 7, 2016

Conversation

mattsherman
Copy link
Contributor

This PR adds the digest category to the email notification settings screen in /me/notifications/updates.

screencapture at thu oct 6 21 48 58 edt 2016

In addition, the existing file was refactored to remove all eslint warnings except for the CSS classname warning -- getting rid of that warning would require more extensive renaming/moving of directories in client/me/notifications-settings, so that is not being done at this time, in order to keep this PR small and focused.

To test this PR:

  • Check and uncheck categories and make sure things are saved/loaded properly and function as before

@mattsherman mattsherman added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature] User & Account Settings (/me) Settings and tools for managing your WordPress.com user account. [Type] Task labels Oct 7, 2016
@mattsherman mattsherman self-assigned this Oct 7, 2016
@matticbot
Copy link
Contributor

Copy link
Contributor

@mjuhasz mjuhasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good. Thank you for the clean-up, you're a good Boy Scout 👍

Tested all categories on calypso.live, worked as expected, no errors or warnings in the console.

Approved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] User & Account Settings (/me) Settings and tools for managing your WordPress.com user account. [Type] Task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants