Editor: Make the AddTerm Component more reusable (revert the revert) #8644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Feature] Post/Page Editor
youknowriad
added
the
[Status] Needs Review
|
Tested with an empty localStore and IndexDB - lets give this one another try 👍 |
timmyc
added
[Status] Ready to Merge
and removed
[Status] Needs Review
timmyc
approved these changes
Oct 11, 2016
| const labels = get( getPostTypeTaxonomy( state, siteId, postType, taxonomy ), 'labels', {} ); | ||
| const taxonomyDetails = getPostTypeTaxonomy( state, siteId, postType, taxonomy ); | ||
| const labels = get( taxonomyDetails, 'labels', {} ); | ||
| const isHierarchical = get( taxonomyDetails, 'hierarchical', false ); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to revert this PR here because of a prod breakage #8588
Here is the revert PR: #8643
The editor was breaking if we did not have a local cache (we did not load the taxonomies yet), It should be fixed now (2nd commit here). So make sure to clear all the local cache to test this.
Testing instructions
cc @timmyc