Reader full post: scope full post action button styles so comment likes aren't affected #8764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluefuton
added
[Type] Bug
[Status] Needs Review
blowery
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In https://github.com/Automattic/wp-calypso/pull/8662/files#diff-6bbcdd387e5ed792d7ef6779d8e9edf0R230 we made all action buttons in full post a consistent text size: 17px.
Unfortunately this caused a small regression with comment likes, which also started appearing at 17px instead of 14px:
This PR scopes the 17px font size to the
.reader-post-actionscomponent.To test
Visit a full post with comments (e.g. http://calypso.localhost:3000/read/feeds/40474296/posts/999143144). In the comments section, ensure that the 'Reply' and 'Like' labels have the same text size.