Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E: Update Revisions editor tests and removing all actions menu item check #92352

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

sejas
Copy link
Member

@sejas sejas commented Jul 3, 2024

Proposed Changes

Why are these changes being made?

Screenshot 2024-07-03 at 13 42 11

From now on we'll track this button:

image

Testing Instructions

  • E2E tests should pass on production and edge sites.
  • Execute: GUTENBERG_EDGE=true NODE_OPTIONS="--inspect" yarn workspace wp-e2e-tests debug -- specs/editor/editor__revisions.ts
  • Execute: NODE_OPTIONS="--inspect" yarn workspace wp-e2e-tests debug -- specs/editor/editor__revisions.ts
  • Observe both tests pass locally

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@sejas sejas self-assigned this Jul 3, 2024
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@sejas sejas changed the title E2E: Update Revisions in editor tests and remove all actions menu checks E2E: Update Revisions editor tests and removing all actions menu item check Jul 4, 2024
@sejas sejas merged commit 8af669d into trunk Jul 4, 2024
17 checks passed
@sejas sejas deleted the remove/e2e-all-actions-revision-menu-item branch July 4, 2024 11:58
gabrielcaires pushed a commit that referenced this pull request Jul 22, 2024
… check (#92352)

* Remove revision menu item and all actions
* Update showRevisionButton target class to
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants