-
Notifications
You must be signed in to change notification settings - Fork 20
Skip domains tests if domain registration is unavailable #1373
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and passes with and without domains working in local testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you be able to include this in the sign up tests also that rely on domains? These will also fail when domains are unavailable. Thanks
Thanks for the update @Stojdza! The manage domains spec works well 👍
With the sign up spec; I couldn't get this to fail because the step still shows just doesn't show paid results: So I was thinking for the sign up tests that register a paid domain only, we could maybe just check the existence of the info message on that screen and abort those tests. The sign up tests that use free wordpress.com addresses don't need to be updated AFAIK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
specs/wp-signup-spec.js
Outdated
@@ -93,7 +94,17 @@ describe( `[${ host }] Sign Up (${ screenSize }, ${ locale })`, function() { | |||
step( | |||
'Can then see the domains page, and Can search for a blog name, can see and select a free .wordpress address in the results', | |||
async function() { | |||
const findADomainComponent = await FindADomainComponent.Expect( driver ); | |||
let findADomainComponent; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to check for unavailability as this uses a free wordpress.com address which doesn't depend on the domains service
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree. I'll add checking only for paid domains and remove these.
This reverts commit baad5d1.
Thanks for this notice @alisterscott, I'll merge it. |
I've added changes for signup spec and update PR description. |
Sorry I didn't get to review this today - @bsessions85: would you mind re-reviewing the latest updates? |
This is looking good to me. I'm curious as to why we're not adding the check in |
@bsessions85 For now there is no way to test it locally, and because of that I left TODO |
🚢 |
Check if domain registration is available, and skip tests if it's not.
To test
wp-manage-domains-spec
:if ( this.state.domainRegistrationAvailable ) {
To test
wp-signup-spec
:NOTE: This includes only
Sign up for a site on a business paid plan w/ domain name coming in via /create as business flow in CAD currency @parallel
test.Result: Tests should be skipped and not failed.
Additional changes:
Sign up for a domain only purchase coming in from wordpress.com/domains in EUR currency @parallel
- Now it opens /domains page and searches for a domain instead opening direct link for a wanted .live domain. This was needed to be done because we will add check for domain registration unavailability in the future.Fixes #1308