Skip to content
This repository has been archived by the owner on Feb 18, 2021. It is now read-only.

Add Embeds to Gutenberg Editor spec #1697

Merged
merged 1 commit into from
Dec 6, 2018
Merged

Add Embeds to Gutenberg Editor spec #1697

merged 1 commit into from
Dec 6, 2018

Conversation

Stojdza
Copy link
Contributor

@Stojdza Stojdza commented Dec 6, 2018

Add Insert embeds: test to wp-gutenberg-post-editor-spec.js

To test:
Make sure that test is passing on mobile and desktop.

@Stojdza Stojdza self-assigned this Dec 6, 2018
@Stojdza Stojdza requested a review from a team December 6, 2018 15:29
@Stojdza Stojdza mentioned this pull request Dec 6, 2018
Closed
JavonDavis
JavonDavis approved these changes Dec 6, 2018
View reviewed changes
Copy link
Contributor

@JavonDavis JavonDavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works well on both desktop and mobile

@JavonDavis JavonDavis merged commit de9038f into master Dec 6, 2018
@Stojdza Stojdza deleted the add/embeds-gutenberg branch December 7, 2018 15:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JavonDavis JavonDavis JavonDavis approved these changes

Assignees

@Stojdza Stojdza

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Stojdza @JavonDavis @matticbot