Jetpack tests: Multiple fixes #1741
Conversation
| // TODO: remove `a.jp-jetpack-connect__button,` after Jetpack 6.9 release | ||
| const selector = By.css( | ||
| "a.jp-jetpack-connect__button,.jp-connect-full__button-container a[href*='register']" | ||
| ); |
There was a problem hiding this comment.
There was a problem hiding this comment.
No. Jetpack 6.9 will introduce new connection splash screen which introduces new connection button.
There was a problem hiding this comment.
Thanks for the clarification @brbrr 👍
| By.css( '.checkout__secure-payment-form,.secure-payment-form' ), | ||
| null, | ||
| 2 * config.get( 'explicitWaitMS' ) | ||
| ); |
There was a problem hiding this comment.
@brbrr here it looks like you've tried to solve the following error: TimeoutError: Timed out waiting for element with css selector of '.checkout__secure-payment-form,.secure-payment-form' to be present and displayed Wait timed out after 20496ms Is it correct? If so, I think it is being caused by the button click issue here instead:
https://github.com/Automattic/wp-e2e-tests/blob/master/lib/pages/plans-page.js#L52
I tested it by placing waitTillNotPresent after clicking on the upgrade to Business Plan button and it showed that after the button is clicked, the test stays on the plans page for some time waiting for the button not to be present. This in turn causes the payment page not to show up on time causing the initial error. I am working on addressing the sleep statement there which should resolve the button click issue. I am yet to find the solution for it.
There was a problem hiding this comment.
Yeah, I think I saw the same error. I wasn't quite sure what the root of the problem, but during visual monitoring, I thought that the problem is that some data weren't loaded in 20sec due to the fact that Jetpack(WPORG) site might not perform as fast as WPCOM sites.
There was a problem hiding this comment.
Thanks for confirming @brbrr! I thought of the same reason originally but after testing with waitTillNotPresent, I could see that the test doesn't leave the plans page. I am still working on figuring out what could be going on there.
There was a problem hiding this comment.
Thanks for patching this up @brbrr! Will merge this to fix failing Jetpack tests
This PR fixes a bunch of small issues which causes jetpack e2e tests to fail.
To test: Check CI job, maybe re-run it.