convert admin ajax endpoints to WP-API endpoints #42
Conversation
Refs #40: Convert admin AJAX endpoints and zone feed to WP-API endpoints Also created Zoninator_Rest_Api_Controller and refactored zoninator into separate classes. Added unit tests for Zoninator_Rest_Api_Controller.
|
You might want to take a look at the pattern we've established for core endpoints. If you follow it, you'll be able to benefit from the abstractions we're creating. |
|
Thanks @danielbachhuber will refactor the Controller class to follow the established pattern. It is sensible to use it's abstractions, especially for ( |
…nd constantize `zoninator`
endpoint section.
Instead, deactivate and gracefully inform the users to either * upgrade their WordPress * downgrade Zoninator to v0.6
| break; | ||
| } | ||
|
|
||
| if( ! call_user_func( array( $this, $verify_function ), $zone_id ) ) { |
There was a problem hiding this comment.
Can we just call the method directly within the switch rather than using call_user_func? Feels like that would make it easier to read/follow.
There was a problem hiding this comment.
Oh, I see it's just a copy-paste of the original function. I think this gives us an an opportunity to improve the code here.
call _permissions->check directly And remove unneeded method `verify_access`
* Use deactivate_plugins * bail_on_activation does not need the $deactivate param
| data = {}; | ||
| } | ||
|
|
||
| zoninator.$zonePostSearch.trigger( 'zoninator.ajax', [ endpoint, method, data ] ); |
There was a problem hiding this comment.
This could be a back-compat issue as well as the original trigger allowed sites to customize the params sent via the AJAX endpoint (e.g. custom search params). Any thoughts on how we could handle this?
…js autocomplete search
And thus remove duplicate (PHP and JS) view template for admin zone post.
Refs #40: Convert admin AJAX endpoints and zone feed to WP-API endpoints
Created
Zoninator_Rest_Api_Controllerclass to represent the new rest API. Amended js code to use the new endpoints.Endpoints
The following endpoints where created
POST /zoninator/v1/zones/:zone_id/posts(add post to zone)GET /zoninator/v1/zones/:zone_id/posts(get zone feed)GET /zoninator/v1/posts/search?term=:term(search term)DELETE /zoninator/v1/zones/:zone_id/posts/:post_id(remove post from zone)PUT /zoninator/v1/zones/:zone_id/posts/order(reorder posts)PUT /zoninator/v1/zones/:zone_id/lock(lock zone)GET /zoninator/v1/zones/:zone_id/posts/recent(recent posts for select box)NOTE: Supplemented the zone feed endpoint with a RESTful endpoint. Did keep the
old zone feed rewrite rule though, as it might be used by third parties.
Other
Refactored
Zoninatorclass in the following waysZoninator_Rest_Api_ControllerandZoninatorinto separate classZoninator_Rest_Api_Controller