Emit TaskCompleted event when a Fixed task is completed #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imstar15
changed the title
imstar15
changed the title
imstar15
force-pushed
the
task-completed-event
branch
from
57895ed
to
7c05ccf
Compare
chrisli30
approved these changes
Jul 19, 2023
v9n
reviewed
Jul 19, 2023
| let my_events = events(); | ||
|
|
||
| let event = my_events.into_iter().find(|e| { | ||
| matches!(e, RuntimeEvent::AutomationTime(crate::Event::TaskCompleted { .. })) |
There was a problem hiding this comment.
should we also assert the TaskId was right as well?
There was a problem hiding this comment.
In the TaskCompleted test, there is only one task, and we do not need to concern ourselves with the task_id parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.