Fix xcmp return weight #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisli30
approved these changes
Aug 3, 2023
format code use u64 add missing trace
v9n
force-pushed
the
fix-xcmp-return-weight
branch
from
b53ad48
to
bcb837a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the old xcmp migration task return weight from
migration_upgrade_xcmp_task. this weight definition is being removed from our benchmark.rs in lastcode, so upon re-generate benchmark, we will lost it.Plus the way substrate mention is count the amount of ops we do to storage. when we loop over the task, we read/insert them back. there is one extra time where we access the whole Storage itself.