Add DescribeBodyTerminal to DescribeAllTerminal #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, Gab! Let us take a look at the changes! |
|
More context from Gab "The DescribeBody terminal is necessary for the HashedDescription to describe XCM locations with the Plurality junction, which we use in our Saturn accounts" |
|
Where are pr no |
chrisli30
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds DescribeBodyTerminal to DescribeAllTerminal, keeping the local implementation of DescribeAllTerminal (in the local primitives crate) in sync with later versions of the Polkadot SDK, where DescribeBodyTerminal was introduced in-between versions 1.1.0 and 1.2.0.
For reference, this is the implementation in v1.2.0.