Return different instruction numbers based on the transactType #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
chrisli30
approved these changes
Nov 29, 2023
| * PayThroughRemoteDerivativeAccount requires 4 XCM instructions, | ||
| * PayThroughSovereignAccount requires 6 instructions. | ||
| * @param transactType | ||
| * @returns The instruction number of XCM instructions | ||
| */ | ||
| // eslint-disable-next-line class-methods-use-this |
There was a problem hiding this comment.
I think we can delete this // eslint-disable-next-line class-methods-use-this since there is no this used in the function
There was a problem hiding this comment.
Yes, the function doesn't use this.
However, we can't remove it. If we delete it, we would have to convert the function into a static method. I prefer not to do that.
https://eslint.org/docs/latest/rules/class-methods-use-this
chrisli30
added a commit
that referenced
this pull request
Dec 28, 2023
* Merge dev_bakup to dev branch (#108) * Add a past time test for dynamic dispatch task (#103) * Add a past time test for dynamic dispatch task * Specific errors were thrown during testing * Fix past time test with time slot * Auto compound interfaces (#99) * Fix adapter * Auto compound interfaces * Remove eslint-disable-next-line import/no-extraneous-dependencies * Update @polkadot/typegen, "@polkadot/types version to ^10.9.1 * Remove ChainData; Add instructionNetworkType to XcmConfig * Add tests for auto-compound * Listen events * Return after the reject or resolve statement * Revert "Return after the reject or resolve statement" This reverts commit a5fe124. * Change ensureBalance to hasEnoughFreeBalance * Rename test case names * If the delegation does not exist, getAutoCompoundingDelegationPercentage return undefined * Add description for Compound tests --------- Co-authored-by: imstar15 <imstar15@qq.com> * Return different instruction numbers based on the transactType (#110) * Renamed chainData to chainConfig in adapters * Added moment library root to fix test/sdk/sdk.test.ts dependency missing problem * Updated to getChainConfig() in test/sdk/sdk.test.ts * Added a temporary fix for MoonbeamAdapter fetchAndUpdateConfigs * Defined build order in package.json to make sure config builds first * Remove from git add from package.json * Upgraded yarn to use the workspace feature * Added root:true to make sure .eslintrc.json works as the root path * Added custom errors to adapter package * Updated dependency of adapter to config@^1.0.0 * Updated the dependencies among our packages * Added isEthereum to all chains in the config package * Added util functions to adapter * Fix WeightToFee function in MangataAdapter (#111) * Fix WeightToFee function in MangataAdapter * Caculate unit by decimals * Change chainData to chainConfig * Fix mangata crossChainTransfer function * Rename x2Params to interior * Format code with .prettierrc * Fixed Github Actions caused by the new yarn berry version (#112) * Try to fix yarn@2 issue caused in Actions * Fix a typo in Release Action * Try to fix dependency missing issue in Actions * Run yarn install with yarn berry version in local environment * Turn off installConfig.immutable in .yarnrc.yml in github Actions * Turn off installConfig.immutable in .yarnrc.yml in github Actions * Added continue-on-error: true to changeset Pull Release in Action * Remove testing trigger branch from .github/workflows/release.yml * Updated Github Actions using yarn berry version * Optimize typescript files based on eslint suggestions * docs(changeset): Updated dependencies among @oak-network/packages to refer to the latest code instead of fixed version * Reverted package reference strategy back to workspace:^1.0.0 (#114) * Reverted package reference strategy back to workspace:^1.0.0 * docs(changeset): Reverted package reference strategy back to workspace:^1.0.0 * Fix publish dev version to NPM Github Actions (#116) * Added ls command to print out the current path in Action * Make sure postbuild script run * Clean up github actions * RELEASING: Releasing 5 package(s) (#115) Releases: @oak-network/api-augment@2.1.1 @oak-network/adapter@0.1.6 @oak-network/config@1.0.1 @oak-network/types@2.1.1 @oak-network/sdk@0.1.6 [skip ci] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * RELEASING: Releasing 5 package(s) (#117) Releases: @oak-network/api-augment@2.1.1 @oak-network/adapter@0.1.6 @oak-network/config@1.0.1 @oak-network/types@2.1.1 @oak-network/sdk@0.1.6 [skip ci] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Update script/package-setup.js (#118) * docs(changeset): SDK and adapter upgrades with automationPrice support * Update package-setup.js * RELEASING: Releasing 2 package(s) (#119) Releases: @oak-network/adapter@0.2.0 @oak-network/sdk@0.2.0 [skip ci] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Export utils constants and errors from adapters (#120) * Export utils constants and errors from adapters * docs(changeset): Export utils constants and errors from adapters * Set the release action to trigger only on main branch * Revert "Set the release action to trigger only on main branch" This reverts commit 67900f5. * RELEASING: Releasing 1 package(s) (#121) Releases: @oak-network/adapter@0.2.1 [skip ci] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Add scheduleAs to task params (#122) * Add scheduleAs to task params * docs(changeset): Add scheduleAs to task params * The scheduleAs parameter should be pass into schedule task function * RELEASING: Releasing 1 package(s) (#123) Releases: @oak-network/sdk@0.2.1 [skip ci] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Change oakAdapter account derivation (#125) * Change oakAdapter account derivation * docs(changeset): Change oakAdapter account derivation * RELEASING: Releasing 2 package(s) (#127) Releases: @oak-network/adapter@0.2.2 @oak-network/sdk@0.2.2 [skip ci] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Rename xtokens to xTokens in astarAdapter (#126) * Rename xtokens to xTokens in astarAdapter * docs(changeset): Rename xtokens to xTokens in astarAdapter * RELEASING: Releasing 1 package(s) (#128) Releases: @oak-network/adapter@0.2.3 [skip ci] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Added currencyId to tokens of Turing chains (#129) * docs(changeset): Export utils constants and errors from adapters * Added currencyId to tokens of Turing chains * docs(changeset): Added currency Id to the tokens registered on Turing chains * Revert "docs(changeset): Export utils constants and errors from adapters" This reverts commit d89c5fd. * RELEASING: Releasing 1 package(s) (#131) Releases: @oak-network/config@1.0.2 [skip ci] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Fix a problem where currencyId is not set on Turing chains (#132) * Fix a problem where currencyId is not set on Turing chains * docs(changeset): Fix a problem where currencyId is not set on Turing chains * RELEASING: Releasing 1 package(s) (#133) Releases: @oak-network/config@1.0.3 [skip ci] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: imstar15 <imstar15@qq.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the xcmp-handler, there are two processes for sending XCM instructions.