Fix crossChainTransfer for the changes in adapter. fix #137 #138
Conversation
|
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
imstar15
changed the title
| }; | ||
|
|
||
| // eslint-disable-next-line import/no-default-export | ||
| export default xtokens; |
There was a problem hiding this comment.
If there are multiple exports, we can use export {abi, address}. That’s why eslint recommends import/no-default-export.
| const moonbeam = { xtokens }; | ||
|
|
||
| // eslint-disable-next-line import/no-default-export | ||
| export default moonbeam; |
There was a problem hiding this comment.
export { moonbeam }; since we will add more chains to this object later, such as {acala, moonbeam, astar}
| const contracts = { astar, moonbeam }; | ||
|
|
||
| // eslint-disable-next-line import/no-default-export | ||
| export default contracts; |
There was a problem hiding this comment.
Try the below lines,
import * from `./astar`;
import * from `./moonbeam`;
export {astar, moonbeam};
packages/adapter/src/utils.ts
Outdated
| /** | ||
| * Determine the account type based on the address. | ||
| * Because 1 byte takes 2 characters in hex string, we can use the length of the address to determine the address type. | ||
| * AccountKey20: 42 characters with prefix 0x. |
There was a problem hiding this comment.
Let’s add the 0x check to this function.
const length = _.startWith(address, "0x")? 42: 40;
packages/adapter/src/utils.ts
Outdated
| * Determine the account type based on the address. | ||
| * Because 1 byte takes 2 characters in hex string, we can use the length of the address to determine the address type. | ||
| * AccountKey20: 42 characters with prefix 0x. | ||
| * AccountId32: 66 characters with prefix 0x. |
There was a problem hiding this comment.
No substrate wallet address contains "0x", so AccountId32 length check should be 64. This function needs to throw an error on all wrong cases instead of using AccountType.AccountId32 as the fall-back.
For example,
if starts with 0x
if length is 42
AccountType.AccountKey20
else
if length is 40
AccountType.AccountKey20
if length is 64
AccountType.AccountId32
throw new Error(`Unrecognized address format`);
* Determine the account type based on the address. * Cross-chain transfer with eth signer * Convert location to precompile multi-location * Add docs references for convertLocationToPrecompileMultiLocation function * Add astar crossChainTransferWithEthSigner function * Set the correct unlimitedWeight when calling astar contract call * Move contract utils to contract-utils.ts * Fix the error in finding the selector * Modify the export method of contracts * Fix the conversion from bytes to bits * An example explaining how to calculate the accountId32 from a Substrate address
* Determine the account type based on the address. * Cross-chain transfer with eth signer * Convert location to precompile multi-location * Add docs references for convertLocationToPrecompileMultiLocation function * Add astar crossChainTransferWithEthSigner function * Set the correct unlimitedWeight when calling astar contract call * Move contract utils to contract-utils.ts * Fix the error in finding the selector * Modify the export method of contracts * Fix the conversion from bytes to bits * An example explaining how to calculate the accountId32 from a Substrate address
crossChainTransferWithEthSignerfunction. It is implemented by calling thextokenscontract on Moonriver.crossChainTransferWithEthSignerfunction. It is implemented by calling thexcmcontract on Shiden.