-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update typescript interface function definion and bump version to 2.0.0 #23
Conversation
133c7ba
to
6b69512
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm I don’t think the events in augment-api-events.ts is updated correctly. Either there’s no logic to pick up the deleted event names, or the local node is still returning them through rpc.
@v9n maybe try to completely delete this file before running the npm scripts?
package.json
Outdated
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "oak.js", | |||
"version": "1.9.0-rc.4", | |||
"version": "2.0.0-rc.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This version needs to be reset to "2.0.0-rc.1", meaning release candidate 1 for 2.0.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks. I just corrected it.
/** | ||
* The result of the DynamicDispatch action. | ||
**/ | ||
DynamicDispatchResult: AugmentedEvent<ApiType, [who: AccountId32, taskId: H256, result: Result<Null, SpRuntimeDispatchError>], { who: AccountId32, taskId: H256, result: Result<Null, SpRuntimeDispatchError> }>; | ||
DynamicDispatchResult: AugmentedEvent<ApiType, [who: AccountId32, taskId: Bytes, result: Result<Null, SpRuntimeDispatchError>], { who: AccountId32, taskId: Bytes, result: Result<Null, SpRuntimeDispatchError> }>; | ||
/** | ||
* Notify event for the task. | ||
**/ | ||
Notify: AugmentedEvent<ApiType, [message: Bytes], { message: Bytes }>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn’t this Notify in automationTime deleted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the Notify
event is still there to support other test. We don't expose the extrins etc but the event still in the Event enum. Let me try to remove them all from the blockchain.
/** | ||
* Notify event for the task. | ||
**/ | ||
Notify: AugmentedEvent<ApiType, [message: Bytes], { message: Bytes }>; | ||
SuccesfullyAutoCompoundedDelegatorStake: AugmentedEvent<ApiType, [taskId: H256, amount: u128], { taskId: H256, amount: u128 }>; | ||
SuccesfullyAutoCompoundedDelegatorStake: AugmentedEvent<ApiType, [taskId: Bytes, amount: u128], { taskId: Bytes, amount: u128 }>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be deleted.
@imstar15, the types package’s code is behind. How do we update the |
This line of configuration also needs to be manually updated to |
6b69512
to
2ae15fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes are published on npm as v2.0.0-rc.1 as tested in xcm-demo code. Good to merge.
@v9n A couple of things to keep in mind of.
- The commit message
regen
is too simple. Please ALWAYS make sure the message explains the reason a code commit. For example, in the case you can useRegenerate the api-augment files with the correct oak-blockchain version v2.0.0
- The previous version of this PR was incorrect. I assumed that the regenerate scripts ran against an old blockchain code version.
@chrisli30 Sounds good. 👍 for the commit message. I will usually rebase and write more description commit before we merge. |
Follow Step 2 and 3
then run:
Note: I changed the port 8855 in the download-metadata script to my local 2.0.0 rpc node port 9946