Adding package to support user activity going forward #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 22, 2024 16:09
…g typescript EB-719
JoeSpanbauer
requested review from
jordan-a-young,
LauRoxx,
gregmartDOTin,
chrishavekost and
nylon22
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #766 +/- ##
==========================================
+ Coverage 84.88% 85.02% +0.13%
==========================================
Files 84 85 +1
Lines 2587 2611 +24
Branches 658 662 +4
==========================================
+ Hits 2196 2220 +24
Misses 391 391 ☔ View full report in Codecov by Sentry. |
owolfhu1
reviewed
Oct 23, 2024
| } | ||
| } | ||
|
|
||
| return undefined |
There was a problem hiding this comment.
Should we return '*' here as a fallback?
There was a problem hiding this comment.
I really only want this to work for our website. I did consider it, though.
chrishavekost
approved these changes
Oct 23, 2024
gregmartDOTin
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.