-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Allow binding
DataGridRow.IsSelected (#16520)
* Change namespace to prevent conflicts. The `DataGrid` in the namespace name was hiding the `DataGrid` type. * Initial impl of bindable DataGridRow.IsSelected. * Make DataGridRow.IsSelected two-way bindable.
- Loading branch information
Showing
7 changed files
with
219 additions
and
28 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
177 changes: 177 additions & 0 deletions
177
tests/Avalonia.Controls.DataGrid.UnitTests/DataGridRowTests.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,177 @@ | ||
| using System; | ||
| using System.Collections; | ||
| using System.Collections.Generic; | ||
| using System.Linq; | ||
| using Avalonia.Data; | ||
| using Avalonia.Markup.Xaml.Styling; | ||
| using Avalonia.Styling; | ||
| using Avalonia.UnitTests; | ||
| using Avalonia.VisualTree; | ||
| using Xunit; | ||
|
|
||
| #nullable enable | ||
|
|
||
| namespace Avalonia.Controls.DataGridTests; | ||
|
|
||
| public class DataGridRowTests | ||
| { | ||
| [Fact] | ||
| public void IsSelected_Binding_Works_For_Initial_Rows() | ||
| { | ||
| using var app = Start(); | ||
| var items = Enumerable.Range(0, 100).Select(x => new Model($"Item {x}")).ToList(); | ||
| items[2].IsSelected = true; | ||
|
|
||
| var target = CreateTarget(items, [IsSelectedBinding()]); | ||
| var rows = GetRows(target); | ||
|
|
||
| Assert.Equal(0, GetFirstRealizedRowIndex(target)); | ||
| Assert.Equal(4, GetLastRealizedRowIndex(target)); | ||
| Assert.All(rows, x => Assert.Equal(x.Index == 2, x.IsSelected)); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void IsSelected_Binding_Works_For_Rows_Scrolled_Into_View() | ||
| { | ||
| using var app = Start(); | ||
| var items = Enumerable.Range(0, 100).Select(x => new Model($"Item {x}")).ToList(); | ||
| items[10].IsSelected = true; | ||
|
|
||
| var target = CreateTarget(items, [IsSelectedBinding()]); | ||
| var rows = GetRows(target); | ||
|
|
||
| Assert.Equal(0, GetFirstRealizedRowIndex(target)); | ||
| Assert.Equal(4, GetLastRealizedRowIndex(target)); | ||
|
|
||
| target.ScrollIntoView(items[10], target.Columns[0]); | ||
| target.UpdateLayout(); | ||
|
|
||
| Assert.Equal(6, GetFirstRealizedRowIndex(target)); | ||
| Assert.Equal(10, GetLastRealizedRowIndex(target)); | ||
|
|
||
| Assert.All(rows, x => Assert.Equal(x.Index == 10, x.IsSelected)); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void Can_Toggle_IsSelected_Via_Binding() | ||
| { | ||
| using var app = Start(); | ||
| var items = Enumerable.Range(0, 100).Select(x => new Model($"Item {x}")).ToList(); | ||
| items[2].IsSelected = true; | ||
|
|
||
| var target = CreateTarget(items, [IsSelectedBinding()]); | ||
| var rows = GetRows(target); | ||
|
|
||
| Assert.Equal(0, GetFirstRealizedRowIndex(target)); | ||
| Assert.Equal(4, GetLastRealizedRowIndex(target)); | ||
| Assert.All(rows, x => Assert.Equal(x.Index == 2, x.IsSelected)); | ||
|
|
||
| items[2].IsSelected = false; | ||
|
|
||
| Assert.All(rows, x => Assert.False(x.IsSelected)); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void Can_Toggle_IsSelected_Via_DataGrid() | ||
| { | ||
| using var app = Start(); | ||
| var items = Enumerable.Range(0, 100).Select(x => new Model($"Item {x}")).ToList(); | ||
| items[2].IsSelected = true; | ||
|
|
||
| var target = CreateTarget(items, [IsSelectedBinding()]); | ||
| var rows = GetRows(target); | ||
|
|
||
| Assert.Equal(0, GetFirstRealizedRowIndex(target)); | ||
| Assert.Equal(4, GetLastRealizedRowIndex(target)); | ||
| Assert.All(rows, x => Assert.Equal(x.Index == 2, x.IsSelected)); | ||
|
|
||
| target.SelectedItems.Remove(items[2]); | ||
|
|
||
| Assert.All(rows, x => Assert.False(x.IsSelected)); | ||
| Assert.False(items[2].IsSelected); | ||
| } | ||
|
|
||
| private static IDisposable Start() | ||
| { | ||
| return UnitTestApplication.Start(TestServices.StyledWindow); | ||
| } | ||
|
|
||
| private static DataGrid CreateTarget( | ||
| IList items, | ||
| IEnumerable<Style>? styles = null) | ||
| { | ||
| var root = new TestRoot | ||
| { | ||
| ClientSize = new(100, 100), | ||
| Styles = | ||
| { | ||
| new StyleInclude((Uri?)null) | ||
| { | ||
| Source = new Uri("avares://Avalonia.Controls.DataGrid/Themes/Simple.xaml") | ||
| }, | ||
| } | ||
| }; | ||
|
|
||
| var target = new DataGrid | ||
| { | ||
| Columns = | ||
| { | ||
| new DataGridTextColumn { Header = "Name", Binding = new Binding("Name") } | ||
| }, | ||
| ItemsSource = items | ||
| }; | ||
|
|
||
| if (styles is not null) | ||
| { | ||
| foreach (var style in styles) | ||
| target.Styles.Add(style); | ||
| } | ||
|
|
||
| root.Child = target; | ||
| root.ExecuteInitialLayoutPass(); | ||
| return target; | ||
| } | ||
|
|
||
| private static int GetFirstRealizedRowIndex(DataGrid target) | ||
| { | ||
| return target.GetSelfAndVisualDescendants().OfType<DataGridRow>().Select(x => x.Index).Min(); | ||
| } | ||
|
|
||
| private static int GetLastRealizedRowIndex(DataGrid target) | ||
| { | ||
| return target.GetSelfAndVisualDescendants().OfType<DataGridRow>().Select(x => x.Index).Max(); | ||
| } | ||
|
|
||
| private static IReadOnlyList<DataGridRow> GetRows(DataGrid target) | ||
| { | ||
| return target.GetSelfAndVisualDescendants().OfType<DataGridRow>().ToList(); | ||
| } | ||
|
|
||
| private static Style IsSelectedBinding() | ||
| { | ||
| return new Style(x => x.OfType<DataGridRow>()) | ||
| { | ||
| Setters = { new Setter(DataGridRow.IsSelectedProperty, new Binding("IsSelected", BindingMode.TwoWay)) } | ||
| }; | ||
| } | ||
|
|
||
| private class Model : NotifyingBase | ||
| { | ||
| private bool _isSelected; | ||
| private string _name; | ||
|
|
||
| public Model(string name) => _name = name; | ||
|
|
||
| public bool IsSelected | ||
| { | ||
| get => _isSelected; | ||
| set => SetField(ref _isSelected, value); | ||
| } | ||
|
|
||
| public string Name | ||
| { | ||
| get => _name; | ||
| set => SetField(ref _name, value); | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters