Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabbing into a ListBox should always focus the selected item #11878

Closed
MrJul opened this issue Jun 23, 2023 · 0 comments · Fixed by #13826
Closed

Tabbing into a ListBox should always focus the selected item #11878

MrJul opened this issue Jun 23, 2023 · 0 comments · Fixed by #13826
Labels
bug

Comments

@MrJul
Copy link
Member

MrJul commented Jun 23, 2023

Describe the bug
Tabbing into a ListBox should always focus the selected item.

To Reproduce
Use the Tab key to navigate into the ListBox in the control catalog's ListBoxPage.
Notice than even though Item 1 is the selected item, Item 0 get focused.
Latest master 714f88e

Expected behavior
The selected item is focused.

Scenarios

  • ❌ An item is selected before the items are realized. Tab focuses the first visible item instead of the selected item.
  • ✔ Select an item keep it into view. Tab focuses the selected item.
  • ❌ Select an item and scroll it out of view. Tab focuses either an incorrect recycled container or nothing instead of the selected item.
  • ❌ Bonus: same as above but with AutoScrollToSelectedItem disabled: since focusing the item isn't possible, it should probably focus the first visible item instead.

Related issue
#11846
@MrJul MrJul added the bug label Jun 23, 2023
@robloo robloo mentioned this issue Nov 25, 2023
Open
5 tasks
grokys added a commit that referenced this issue Dec 4, 2023
@grokys
Add failing unit test for scenario 1 in #11878.
c70274f
grokys added a commit that referenced this issue Dec 4, 2023
@grokys
Set TabOnceActiveElement on realized container.
de9b380 
Fixes scenario 1 in #11878.
grokys added a commit that referenced this issue Dec 4, 2023
@grokys
Use TabOnceActiveElement to decide focused element.
2d303eb 
Fixes scenario #3 in #11878.
@grokys grokys mentioned this issue Dec 4, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Dec 5, 2023
@grokys
Fix some issues with tabbing into virtualized list (#13826)
62314a0 
* Add failing unit test for scenario 1 in #11878.

* Set TabOnceActiveElement on realized container.

Fixes scenario 1 in #11878.

* Use TabOnceActiveElement to decide focused element.

Fixes scenario #3 in #11878.
maxkatz6 pushed a commit that referenced this issue Dec 5, 2023
@grokys @maxkatz6
Fix some issues with tabbing into virtualized list (#13826)
cd8ab64 
* Add failing unit test for scenario 1 in #11878.

* Set TabOnceActiveElement on realized container.

Fixes scenario 1 in #11878.

* Use TabOnceActiveElement to decide focused element.

Fixes scenario #3 in #11878.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix some issues with tabbing into virtualized list AvaloniaUI/Avalonia
1 participant
@MrJul