Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event trigger time in DevTools. #11338 #12036

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

yll690
Copy link
Contributor

@yll690 yll690 commented Jul 5, 2023

What does the pull request do?

Add event trigger time in DevTools.

What is the current behavior?

Events in list have no time.

What is the updated/expected behavior with this PR?

Each event record has its trigger time in the left of the line.

How was the solution implemented (if it's not obvious)?

Add a TriggerTime property to FiredEvent and use the time where EventTreeNode.HandleEvent triggered as the event trigger time

Checklist

Breaking changes

No

Obsoletions / Deprecations

No

Fixed issues

Fixes #11338

@yll690
Copy link
Contributor Author

yll690 commented Jul 5, 2023 via email

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0037378-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6
Copy link
Member

maxkatz6 commented Jul 5, 2023

Thank you!

@maxkatz6 maxkatz6 added this pull request to the merge queue Jul 5, 2023
Merged via the queue into AvaloniaUI:master with commit 605c880 Jul 5, 2023
@yll690 yll690 deleted the feature/devtools-event-time branch July 6, 2023 01:10
@MarnixCroes
Copy link

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DevTools] show time of event
4 participants