Use CancellationToken in AvaloniaNameGenerator

[jankrib]

What does the pull request do?

I was experiencing severe performance issues in visual studio with a larger project with many axaml files. The better solution here is probably to implement the newer IIncrementalGenerator interface, but I noticed that the generation was not using the CancellationToken. This made a huge difference for me.

What is the current behavior?

It keeps generating all the xaml files even if the operation is cancelled

What is the updated/expected behavior with this PR?

The generation is cancelled if the CancellationToken reports so.

How was the solution implemented (if it's not obvious)?

I tried to churn as little as possible, but had to change the return type from IReadOnlyList to IEnumerable to get the lazy behavior wanted by the foreach loop.

Checklist

• Added unit tests (if possible)?
• Added XML documentation to any related classes?
• Consider submitting a PR to https://github.com/AvaloniaUI/Documentation with user documentation

Breaking changes

Obsoletions / Deprecations

Fixed issues

[avaloniaui-team]

You can test this PR using the following package version. 11.0.999-cibuild0037391-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

[timunie]

I think incremental generator was planned, but not available back then. Don't know how easy it would be to implement that interface at this stage though.

[jankrib]

I looked into it. It is pretty trivial but requires refactoring. I gave it a quick go, but the way options are made from the old context made me try this simple fix instead. Using it now it doesn't feel slow and the project is quite large.

[avaloniaui-team]

You can test this PR using the following package version. 11.0.999-cibuild0037432-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]